Skip to content

Lambda usage simplifications #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

egsavage
Copy link
Contributor

Title (required)

Fixes #1926 (partially) - Code quality changes

Description (required)

Fixes #1926 (partially) - Code quality changes

Lambda usage simplifications across the project.

Tests performed (required)

Basic compilation at this point.

@codecov-io
Copy link

Codecov Report

Merging #1928 into master will increase coverage by <.01%.
The diff coverage is 1.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1928      +/-   ##
=========================================
+ Coverage    3.71%   3.71%   +<.01%     
=========================================
  Files         192     192              
  Lines        9915    9896      -19     
  Branches      886     886              
=========================================
  Hits          368     368              
+ Misses       9520    9501      -19     
  Partials       27      27
Impacted Files Coverage Δ
.../free/nrw/commons/upload/SingleUploadFragment.java 0% <0%> (ø) ⬆️
...c/main/java/fr/free/nrw/commons/AboutActivity.java 0% <0%> (ø) ⬆️
...free/nrw/commons/wikidata/WikidataEditService.java 0% <0%> (ø) ⬆️
...explore/recentsearches/RecentSearchesFragment.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java 0% <0%> (ø) ⬆️
.../fr/free/nrw/commons/widget/PicOfDayAppWidget.java 0% <0%> (ø) ⬆️
...r/free/nrw/commons/auth/AuthenticatedActivity.java 0% <0%> (ø) ⬆️
...nrw/commons/notification/NotificationActivity.java 0% <0%> (ø) ⬆️
...in/java/fr/free/nrw/commons/quiz/QuizActivity.java 0% <0%> (ø) ⬆️
...a/fr/free/nrw/commons/quiz/QuizResultActivity.java 0% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e4d96...ef2e6ea. Read the comment docs.

@domdomegg domdomegg self-requested a review November 2, 2018 18:24
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested tutorial, login, home, about (inc. tranlate wiki link), explore (inc. searching and checking recent searches) and viewing media.

2.8.3-debug-pr-1928~ef2e6ea6 on Samsung Galaxy S6 with API level 25.
2.8.3-debug-pr-1928~ef2e6ea6 on Galaxy Nexus (simulated) with API level 28.

Results:

  • All working perfectly

@domdomegg domdomegg merged commit e8f4a28 into commons-app:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants