Feature #1756 : Bookmark System #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in/apps-android-commons into feature/1756_bookmark
When user come back from detail picture fragment, it solve the refresh bug.
…in/apps-android-commons into feature/1756_bookmark
…in/apps-android-commons into feature/1756_bookmark
Codecov Report
@@ Coverage Diff @@
## master #1935 +/- ##
=========================================
- Coverage 4.54% 4.36% -0.19%
=========================================
Files 199 211 +12
Lines 10113 10646 +533
Branches 900 951 +51
=========================================
+ Hits 460 465 +5
- Misses 9618 10146 +528
Partials 35 35
Continue to review full report at Codecov.
|
Contributor
|
@R0ma1nG Thanks for the PR. I tried testing it and the app crashes as soon as I click on bookmarks. Here are the logs: Note: I didn't do a fresh install. If the user already has the app installed, you should handle it using sqlite migrations ie |
Contributor
|
Great work @R0ma1nG!! I tested the feature on a fresh install and it works like a charm. I tried the following things:
Am happy to do a code review and merge this PR once the upgrade thing is fixed. :) |
Member
|
Looks great! |
|
Hey @maskaravivek |
maskaravivek
approved these changes
Oct 15, 2018
Contributor
maskaravivek
left a comment
There was a problem hiding this comment.
Great work @R0ma1nG! The code quality looks good and it is nice to see that you have added a lot of test cases.
I am happy to merge it once someone else also tests it. :)
| import fr.free.nrw.commons.auth.AuthenticatedActivity; | ||
| import fr.free.nrw.commons.media.MediaDetailPagerFragment; | ||
|
|
||
| public class BookmarksActivity extends AuthenticatedActivity |
Contributor
There was a problem hiding this comment.
IMO this feature can be used without the user logging in. In that case, you don't need to extend AuthenticatedActivity
| Media m = provider.getMediaAtPosition(pager.getCurrentItem()); | ||
| switch (item.getItemId()) { | ||
| case R.id.menu_bookmark_current_image: | ||
| // TODO Update image state in database and in UI |
Contributor
There was a problem hiding this comment.
Has this todo being taken care of?
Change from AuthenticatedActivity to BaseNavigationActivity
Member
|
Wow, fantastic PR! Merging, thanks for the great job @Victor-Bonin and @R0ma1nG . :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bookmark System
Fixes #1756
Creation of a new section Bookmarks in the navigation drawer, divided in 2 tabs.
Those tabs list the user's bookmarked media and places using the previsouly used display.
When clicking a media or a location you can access its details. From the details screen you can now save the picture or place, or unsave it if it is already bookmarked.
Creation of a new package : bookmarks including both subpackages locations and pictures
The subpackages have their own DAO, ContentProvider, Controller and Fragment.
Creation of corresponding tests.
Tests performed (required)
Tested on API level 24 (Samsung Galaxy S6) & 28 (Emulator Pixel 2), with betaDebug & betaRelease.
Screenshots :