Empty screen if no upload fix #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, message gets wiped after any picture is inserted into the list
Codecov Report
@@ Coverage Diff @@
## master #1940 +/- ##
=========================================
- Coverage 4.55% 4.54% -0.01%
=========================================
Files 199 199
Lines 10108 10113 +5
Branches 899 900 +1
=========================================
Hits 460 460
- Misses 9613 9618 +5
Partials 35 35
Continue to review full report at Codecov.
|
| android:layout_height="wrap_content" | ||
| android:text="@string/no_uploads" | ||
| android:gravity="center" | ||
| android:layout_centerInParent="true" |
Contributor
There was a problem hiding this comment.
Add left and right margins please :)
Member
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title (required)
Fixes #1912 Empty screen if no upload
Description (required)
Fixes #1912 Empty screen if no upload
Added text view for empty page showing welcome text in case there are no uploads. Once there are files the message is hid.
Tests performed (required)
Tested on API 25 & Galaxy J5, with {BetaDebug}
Screenshots showing what changed (optional)
Without and with uploads: