Fixes #2001 New main UI - progress bar in Nearby card view sometimes runs forever. #2021
Conversation
* Bug fix issue commons-app#1826 Changes made : -Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe * review suggested changes *Code formatting *Extracted out the index of pipe in a variable *Added issue link in comments
* Remove libraries section from README * Add wiki link to "libraries used" to README
Codecov Report
@@ Coverage Diff @@
## 2.9-release #2021 +/- ##
==============================================
- Coverage 4.13% 4.09% -0.05%
==============================================
Files 223 223
Lines 11227 11243 +16
Branches 1032 1030 -2
==============================================
- Hits 464 460 -4
- Misses 10728 10749 +21
+ Partials 35 34 -1
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| private void displayYouWontSeeNearbyMessage() { | ||
| ViewUtil.showLongToast(getActivity(), "You wont see narby place since you didn't gave permission"); |
There was a problem hiding this comment.
Please make this a string resource and change it to "Unable to display nearest place that needs pictures without location permissions".
app/src/main/res/values/strings.xml
Outdated
| @@ -414,5 +414,7 @@ Upload your first media by touching the camera or gallery icon above.</string> | |||
| <string name="no_go_back">No, Go Back</string> | |||
|
|
|||
| <string name="upload_flow_all_images_in_set">(For all images in set)</string> | |||
| <string name="nearby_card_permission_title">Permission Request</string> | |||
| <string name="nearby_card_permission_explanation">Please give location permission to see the nearest place that needs pictures</string> | |||
There was a problem hiding this comment.
Please change this to "Would you like us to use your current location to display the nearest place that needs pictures?"
|
@neslihanturan I just tested your PR on a Samsung Galaxy S7 running API 26. The general flow works well if the user agrees to all permissions, and the loading works well also. :) Some changes are needed however:
|
|
Ready to be tested @misaochan :) |
|
@neslihanturan It works now and does not spam the user. Great job! :) I will go ahead and merge this, but there is one minor scenario that would be good if we can fix in 2.9.1. If I deny permissions in the dialog, then 'reset' it by enabling location permissions via Android settings and disabling again, instead of displaying the appropriate dialog, it instead displays the dialog "Permission required to display a list of nearby places". Even though I'm on Contributions tab. However, that is a minor issue (I doubt too many users will be doing that), so it need not block the release. :) |
Description (required)
Fixes #2001 New main UI - progress bar in Nearby card view sometimes runs forever.
Nearby card notification is only visible if closest nearby item is loaded successfully.
Tests performed (required)
Tested on API 26, prodDebug and betaDebug.