Bug fix, issue #2029 NPE after tapping image in Explore #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initialise MediaDetailProvider in based on its type as in activity or fragment
maskaravivek
approved these changes
Nov 26, 2018
Contributor
maskaravivek
left a comment
There was a problem hiding this comment.
Looks good to me. :)
Codecov Report
@@ Coverage Diff @@
## 2.9-release #2036 +/- ##
==============================================
- Coverage 4.07% 4.06% -0.01%
==============================================
Files 224 224
Lines 11299 11309 +10
Branches 1043 1045 +2
==============================================
Hits 460 460
- Misses 10805 10815 +10
Partials 34 34
Continue to review full report at Codecov.
|
neslihanturan
approved these changes
Nov 26, 2018
Collaborator
neslihanturan
left a comment
There was a problem hiding this comment.
Thanks @ashishkumar468 , seems good to me:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Media Details used to crashed when opened via Explore
Fixes #2029 NPE after tapping image in Explore
What changes did you make and why?
Initialise MediaDetailProvider based on its type as in activity or fragment
Tests performed (required)
Tested {build variant, ProdDebug} on {OnePlus 3T} with API level {27}.
Screenshots showing what changed (optional - for UI changes)
NA