Bug fix issue #2042 (Blank Achievements Activity) #2050
Conversation
* Added a sticky snack bar in achievements activity which shows up when fetch api fails * Snackbar comes with an action button which on click retries fetch. This way user is never shown a blank screen and always has an option to retry fetches
app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java
Outdated
Show resolved
Hide resolved
…able name in ViewUtil
Codecov Report
@@ Coverage Diff @@
## master #2050 +/- ##
=========================================
- Coverage 4.05% 4.04% -0.01%
=========================================
Files 225 225
Lines 11357 11374 +17
Branches 1048 1049 +1
=========================================
Hits 460 460
- Misses 10863 10880 +17
Partials 34 34
Continue to review full report at Codecov.
|
|
Hi @ashishkumar468 , I'm sorry that I didn't clarify. AFAIK for this user, Achievements NEVER loads (although I messaged him to double check). I was hoping we could look into that. His full logs are in the private repo, I only posted part of it - so if the username and error log is insufficient, we can look at the bigger picture. |
|
Thanks @ashishkumar468 ! It works perfect for users who had temporary problems with loading achievements. But I won't merge this since @misaochan requested a more complete solution for users who experience permanent issues with that. |
|
Added a separate pr for the fix, needed base branch changes. Closing this one |
Description (required)
When the api call to fetch the achievements somehow fails, a blank screen shows up and user is left with no option to retry.
Fixes #2042 Achievements is blank for some users.
What changes did you make and why?
Tests performed (required)
Tested {build variant, ProdDebug} on {One Plus 3T} with API level {27}.
Screenshots showing what changed (optional - for UI changes)
