Skip to content

Fix orientation issue on nearby after "search this area" is implemented #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neslihanturan
Copy link
Collaborator

Description (required)

Fixes issue mentioned on last comment of #2051
What changes did you make and why?

Tests performed (required)

Tested on prodDebug API 19 and 26

@codecov-io
Copy link

Codecov Report

Merging #2085 into master will increase coverage by 1.66%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2085      +/-   ##
=========================================
+ Coverage    4.02%   5.68%   +1.66%     
=========================================
  Files         226     233       +7     
  Lines       11467   11603     +136     
  Branches     1064    1077      +13     
=========================================
+ Hits          461     660     +199     
+ Misses      10972   10888      -84     
- Partials       34      55      +21
Impacted Files Coverage Δ
...ava/fr/free/nrw/commons/nearby/NearbyFragment.java 0% <0%> (ø) ⬆️
...r/free/nrw/commons/contributions/MainActivity.java 0% <0%> (ø) ⬆️
.../fr/free/nrw/commons/nearby/NearbyMapFragment.java 0% <0%> (ø) ⬆️
...a/fr/free/nrw/commons/utils/ContributionUtils.java 6.77% <0%> (-5.35%) ⬇️
...n/java/fr/free/nrw/commons/CommonsApplication.java 41.77% <0%> (-2.14%) ⬇️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️
.../nrw/commons/nearby/NearbyNoificationCardView.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/nearby/PlaceRenderer.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/nearby/NearbyListFragment.java 0% <0%> (ø) ⬆️
...free/nrw/commons/wikidata/WikidataEditService.java 0% <0%> (ø) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677e009...520c303. Read the comment docs.

@misaochan
Copy link
Member

Thanks @neslihanturan !

@misaochan misaochan merged commit 3399576 into commons-app:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants