Show campaigns #2113
Merged
Show campaigns #2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a ui util class SwipableCardView which passes the onSwipe event to its children * NearbyCardView & CampaignView extend SwipableCardView * Fetch campaigns in ContributionsFragment * Added an option to enable disable campaign in Settings/Preferences
Codecov Report
@@ Coverage Diff @@
## master #2113 +/- ##
=========================================
- Coverage 5.6% 5.49% -0.11%
=========================================
Files 225 231 +6
Lines 11379 11546 +167
Branches 1065 1075 +10
=========================================
- Hits 638 635 -3
- Misses 10689 10859 +170
Partials 52 52
Continue to review full report at Codecov.
|
maskaravivek
approved these changes
Dec 14, 2018
|
Thanks for the review @maskaravivek :-) |
|
Looks amazing @ashishkumar468 , great job! |
neslihanturan
approved these changes
Dec 14, 2018
|
Thanks @neslihanturan :-) |
|
Not sure if related, but I tested this with Nexus S API 27 and this was my result:
|
@misaochan JO, This is not related to this PR, as you've writen that you altered the date on your device, this was due to that, my best guess is that some api is based on timestamp validation, which fails as we've altered it. Could you verify this on your end by actually putting valid dates in the json ? |
|
Yes, the crash does not happen if the dates are not altered. :) Please create a new issue, I will merge this! |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Show ongoing campaigns on home screen
Fixes #78 {Show news about ongoing campaigns/competitions}
What changes did you make and why?
Tests performed (required)
Tested {build variant, ProdDebug} on OnePlus 3T with API level {26}
Screenshots showing what changed (optional - for UI changes)
