Skip to content

Conversation

@domdomegg
Copy link
Member

Description (required)

Removes utils/FileUtils to simplify project organisation, particularly as there are two (the other is upload.FileUtils) and none of the code in it is actually used.

It had 2 methods, both of which were used once. Also the function (in ContributionUtils) that calls them is never used. However in case it is useful in the future I've moved the methods to ContributionUtils. I also improved the structure of ContributionUtils.decideTempDestinationFileName slightly.

Tests performed (required)

All automated tests pass

Tested 2.9.0-debug-delete-utils-fileutils~08b5f85e on Samsung Galaxy S6 with API level 25.

@codecov-io
Copy link

Codecov Report

Merging #2118 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2118      +/-   ##
=========================================
+ Coverage    5.49%    5.5%   +<.01%     
=========================================
  Files         231     230       -1     
  Lines       11546   11536      -10     
  Branches     1075    1074       -1     
=========================================
  Hits          635     635              
+ Misses      10859   10849      -10     
  Partials       52      52
Impacted Files Coverage Δ
...a/fr/free/nrw/commons/utils/ContributionUtils.java 7.14% <0%> (-4.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40c5ed...22ce5ca. Read the comment docs.

Copy link
Contributor

@maskaravivek maskaravivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for consolidating the FileUtils.

@maskaravivek maskaravivek merged commit 8f0a619 into commons-app:master Dec 17, 2018
@domdomegg domdomegg deleted the delete-utils-fileutils branch March 17, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants