Skip to content

Conversation

@ashishkumar468
Copy link
Collaborator

Description (required)

Fixes #78 Show news about ongoing campaigns/competitions

What changes did you make and why?

  • Sort the campaigns by date, and show the campaign whose
    startDate<=currentDate<=endDate

Tests performed (required)

Tested {build variant, ProdDebug} on {One Plus 3T} with API level {26}.

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #2119 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2119      +/-   ##
=========================================
+ Coverage    5.49%   5.52%   +0.02%     
=========================================
  Files         231     234       +3     
  Lines       11546   11598      +52     
  Branches     1075    1080       +5     
=========================================
+ Hits          635     641       +6     
- Misses      10859   10904      +45     
- Partials       52      53       +1
Impacted Files Coverage Δ
...free/nrw/commons/campaigns/CampaignsPresenter.java 0% <0%> (ø) ⬆️
...ain/java/fr/free/nrw/commons/upload/FileUtils.java 2.13% <0%> (-0.1%) ⬇️
...java/fr/free/nrw/commons/nearby/PlaceRenderer.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/nearby/NearbyListFragment.java 0% <0%> (ø) ⬆️
...free/nrw/commons/wikidata/WikidataEditService.java 0% <0%> (ø) ⬆️
...ava/fr/free/nrw/commons/upload/UploadActivity.java 0% <0%> (ø) ⬆️
.../commons/contributions/ContributionController.java 0% <0%> (ø) ⬆️
...nrw/commons/notification/NotificationRenderer.java 0% <0%> (ø) ⬆️
...bookmarks/locations/BookmarkLocationsFragment.java 0% <0%> (ø) ⬆️
...ain/java/fr/free/nrw/commons/utils/ImageUtils.java 0% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867e447...f6f938a. Read the comment docs.

@misaochan
Copy link
Member

@ashishkumar468 , does this work for you? I changed https://github.com/commons-app/campaigns/blob/master/campaigns.json to end on 30 Dec, but no campaign is displaying for me.

@misaochan
Copy link
Member

Works perfectly now, thanks! :)

@misaochan misaochan merged commit 4425c36 into commons-app:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants