Fixed problem with crashing SearchActivity after orientation change #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Build problem fix a duplicate of #2028 |
Member
|
Can you make this one just target #2125? |
Contributor
Author
|
@domdomegg done. |
Member
|
Change seems okay, tested on API levels 25 and 28. Don't know if it fixes the issue as was unable to recreate. Given the documentation, think it's still worth merging even if bug irrelevant. |
Member
|
This does fix the issue - although I believe the 'true' issue might be deeper. Merging this as does prevent the crash and also recommended by documentation. |
domdomegg
approved these changes
Dec 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Resolves #2125
What changes did you make and why?
https://developer.android.com/guide/topics/manifest/activity-element#config
"If your application targets Android 3.2 (API level 13) or higher, then you should also declare the "screenSize" configuration, because it also changes when a device switches between portrait and landscape orientations." - from docs.