Skip to content

Conversation

@domdomegg
Copy link
Member

Description (required)

Fixes #2123 Crashes viewing media in explore mode

What changes did you make and why?

Removed unnecessary getParentFragment() calls. I'm not sure why it is used here given getActivity() should already go up the chain until it reaches the calling activity or returns null.

Tests performed (required)

All automated tests pass.

Tested 2.9.0-debug-hotfix-explore-media-detail~7b5e1068 on Galaxy Nexus (emulator) with API level 28.
Tested 2.9.0-debug-hotfix-explore-media-detail~7b5e1068 on Samsung Galax S6 with API level 25.

@codecov-io
Copy link

Codecov Report

Merging #2138 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2138   +/-   ##
======================================
  Coverage    5.52%   5.52%           
======================================
  Files         234     234           
  Lines       11596   11596           
  Branches     1079    1079           
======================================
  Hits          641     641           
  Misses      10902   10902           
  Partials       53      53
Impacted Files Coverage Δ
...ee/nrw/commons/media/MediaDetailPagerFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102b2d7...7b5e106. Read the comment docs.

@neslihanturan
Copy link
Collaborator

Thanks @domdomegg , works as expected.

@neslihanturan neslihanturan merged commit f66d02c into commons-app:master Dec 17, 2018
@domdomegg domdomegg deleted the hotfix-explore-media-detail branch December 17, 2018 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App crashing on clicking any search result in Explore

4 participants