Travis should only sign and build APK on master branch #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2162 +/- ##
======================================
Coverage 5.69% 5.69%
======================================
Files 233 233
Lines 11593 11593
Branches 1076 1076
======================================
Hits 660 660
Misses 10878 10878
Partials 55 55Continue to review full report at Codecov.
|
maskaravivek
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #1056
What changes did you make and why?
Travis now checks we're on the master branch before pushing a release to Google Play. Otherwise, things like this will create an alpha build for Google Play:
https://travis-ci.org/commons-app/apps-android-commons/builds/468986786
(Worked on a non-master branch of commons-app, which resulted in Travis running a
continuous-integration/travis-ci/pushbuild - see #2148)Tests performed (required)
Not really able to test, so need someone to look at carefully.