Skip to content

Fix #2210: Fix inputs not being easily visible #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2019
Merged

Fix #2210: Fix inputs not being easily visible #2211

merged 1 commit into from
Jan 1, 2019

Conversation

domdomegg
Copy link
Member

@domdomegg domdomegg commented Dec 21, 2018

Description

Fixes #2210

What changes did you make and why?

  • Moved the theme-ing for the search bar into its own theme so it does not affect inputs in SettingsFragment

Tests performed

Tested 2.9.0-debug-fix-2210~a220c58af on Galaxy Nexus (emulator) with API level 28

Settings fixed Search still looks right
screenshot_1545421344 screenshot_1545421357

@codecov-io
Copy link

Codecov Report

Merging #2211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2211   +/-   ##
======================================
  Coverage    5.87%   5.87%           
======================================
  Files         231     231           
  Lines       11587   11587           
  Branches     1078    1078           
======================================
  Hits          681     681           
  Misses      10849   10849           
  Partials       57      57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493fa6b...a220c58. Read the comment docs.

@maskaravivek
Copy link
Member

Thanks for the fix @domdomegg. It works for me. :)

@maskaravivek maskaravivek merged commit 5c8a0cd into commons-app:master Jan 1, 2019
@domdomegg domdomegg deleted the fix-2210 branch January 1, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor 'invisible' in some fields on white background
3 participants