Use large heap size for commons app #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskaravivek
commented
Jan 2, 2019
| @@ -35,16 +35,16 @@ | |||
|
|
|||
| public class ImageUtils { | |||
There was a problem hiding this comment.
Changes in this file are to fix variable/method scopes in ImageUtils.
Codecov Report
@@ Coverage Diff @@
## master #2261 +/- ##
=========================================
+ Coverage 5.88% 5.88% +<.01%
=========================================
Files 231 231
Lines 11606 11604 -2
Branches 1082 1082
=========================================
Hits 683 683
+ Misses 10865 10863 -2
Partials 58 58
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #2083
This is the first step towards fixing Out of memory crashes while processing large bitmaps in Commons app. Based on a suggestion in this thread.
https://stackoverflow.com/questions/42053173/simple-android-app-out-of-memory-error-when-running-on-smartphone
The next step would be to optimize the decoding of
Bitmap. Some suggestions on how to achieve it can be seen on this thread.https://stackoverflow.com/questions/11820266/android-bitmapfactory-decodestream-out-of-memory-with-a-400kb-file-with-2mb-f