-
Notifications
You must be signed in to change notification settings - Fork 1.3k
modified date format #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified date format #2341
Conversation
app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2341 +/- ##
======================================
Coverage 5.94% 5.94%
======================================
Files 237 237
Lines 11348 11348
Branches 1022 1022
======================================
Hits 675 675
Misses 10620 10620
Partials 53 53
Continue to review full report at Codecov.
|
Found this in Wikipedia's code base:
calling it like:
|
@maskaravivek does this getBestDateTimePattern supplies approiate ormat for different languages? |
Looks like! You will have to play around a bit. :) |
app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java
Outdated
Show resolved
Hide resolved
@maskaravivek I have added the function in DateUtil. |
Could you please post a screenshot in Japanese? An important difference of Japanese is that it places the year first. |
@nicolas-raoul Can you suggest me any other such language. Actually my phone doesn't supports japanese |
I suggest Chinese or Persian (Iran). |
OK I'll check that out 👍 |
@nicolas-raoul I have tried for each color zone |
The screenshots look perfect :-) |
Good to see this :) |
Thanks for approving the Pull Request :) |
Earler the date wasn't correctly localized Changing format of display date in SimpleDateFormat function brings it to the format as mentioned
Fixes #2336 Image details: date not correctly localized in Japanese
What changes did you make and why?
Modified media detail fragment