Skip to content

Made nearby notification also visible to right-to-left languages #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

vanshikaarora
Copy link
Contributor

Description (required)

Fixes #2334 Nearby notification empty in right-to-left languages

Changes made

Modified the nearby_card_view

Screenshots showing what changed (optional - for UI changes)

whatsapp image 2019-01-27 at 9 37 41 pm

@codecov-io
Copy link

codecov-io commented Jan 27, 2019

Codecov Report

Merging #2365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2365   +/-   ##
======================================
  Coverage    5.96%   5.96%           
======================================
  Files         237     237           
  Lines       11354   11354           
  Branches     1022    1022           
======================================
  Hits          677     677           
  Misses      10624   10624           
  Partials       53      53
Impacted Files Coverage Δ
...nrw/commons/nearby/NearbyNotificationCardView.java 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82e3b9...2a84cb0. Read the comment docs.

@nicolas-raoul
Copy link
Member

The screenshot looks like it fixes the problem correctly :-)

@nicolas-raoul
Copy link
Member

Just checking: this does not modify how the screen looks in left-to-right languages, right?

@vanshikaarora
Copy link
Contributor Author

@nicolas-raoul I have testes the code for both the type of cases before sending the PR.
Here is a screenshot for the same code in a left-to-right language

whatsapp image 2019-01-28 at 4 55 23 pm

Copy link
Member

@misaochan misaochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge after a third party has tested it.

@vanshikaarora
Copy link
Contributor Author

Thanks @misachan for approving the changes :)

@vanshikaarora
Copy link
Contributor Author

@maskaravivek @nicolas-raoul Can you please review the PR :)

@vanshikaarora
Copy link
Contributor Author

@maskaravivek @misaochan @ashishkumar468 Can you please review the PR :)

@maskaravivek
Copy link
Member

Code changes look good to me so I am going ahead and merging it. Our alpha users can help us test this. :)

@maskaravivek maskaravivek merged commit 105e5d7 into commons-app:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants