-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Made nearby notification also visible to right-to-left languages #2365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
======================================
Coverage 5.96% 5.96%
======================================
Files 237 237
Lines 11354 11354
Branches 1022 1022
======================================
Hits 677 677
Misses 10624 10624
Partials 53 53
Continue to review full report at Codecov.
|
The screenshot looks like it fixes the problem correctly :-) |
Just checking: this does not modify how the screen looks in left-to-right languages, right? |
@nicolas-raoul I have testes the code for both the type of cases before sending the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy to merge after a third party has tested it.
Thanks @misachan for approving the changes :) |
@maskaravivek @nicolas-raoul Can you please review the PR :) |
@maskaravivek @misaochan @ashishkumar468 Can you please review the PR :) |
Code changes look good to me so I am going ahead and merging it. Our alpha users can help us test this. :) |
Description (required)
Fixes #2334 Nearby notification empty in right-to-left languages
Changes made
Modified the nearby_card_view
Screenshots showing what changed (optional - for UI changes)