Skip to content

Conversation

@ShridharGoel
Copy link
Contributor

Description (required)

Fixes #2390

What changes did you make and why?

Added same functionality as the arrow-shaped button to the Step 1 bottom card as a whole.

Tests performed (required)

Tested betaDebug on Android 7.1.2 (API 25)

GIF showing what changed (optional - for UI changes)

ezgif com-video-to-gif 34

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@1692705). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2391   +/-   ##
========================================
  Coverage          ?   5.93%           
========================================
  Files             ?     238           
  Lines             ?   11364           
  Branches          ?    1028           
========================================
  Hits              ?     674           
  Misses            ?   10637           
  Partials          ?      53
Impacted Files Coverage Δ
...ava/fr/free/nrw/commons/upload/UploadActivity.java 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1692705...d547d25. Read the comment docs.

@ShridharGoel ShridharGoel changed the title Fix #2390: Toggle state of bottom card on click Toggle state of bottom card on click Feb 2, 2019
@maskaravivek maskaravivek merged commit 6365815 into commons-app:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants