Skip to content

Complete removal of Campaigns feature #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Aug 31, 2016

Unused layouts and messages

@jayvdb
Copy link
Contributor Author

jayvdb commented Aug 31, 2016

This is being reconsidered in #100 , but IMO it should be re-designed as well.
And potential translators shouldn't be seeing unused messages.

@jayvdb
Copy link
Contributor Author

jayvdb commented Aug 31, 2016

Note I havent tested this , but the layouts are not in the manifest, etc.

@nicolas-raoul nicolas-raoul merged commit c1274cf into commons-app:master Aug 31, 2016
jayvdb added a commit to jayvdb/apps-android-commons that referenced this pull request Sep 7, 2016
This was already done in commons-app#240, but re-introduced in 4b01f6e.
@jayvdb jayvdb mentioned this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants