Feature to zoom images #2427
Closed
Feature to zoom images #2427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2427 +/- ##
=========================================
- Coverage 2.77% 2.77% -0.01%
=========================================
Files 259 260 +1
Lines 12364 12375 +11
Branches 1116 1118 +2
=========================================
Hits 343 343
- Misses 11994 12005 +11
Partials 27 27
Continue to review full report at Codecov.
|
maskaravivek
requested changes
Feb 7, 2019
171f0f2 to
d48b4f3
Compare
c33c39d to
27b4c16
Compare
|
@maskaravivek Updated. Added new GIF also. |
|
Waiting hard for this to come to #pluspora... |
|
Can someone please review this? |
app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java
Outdated
Show resolved
Hide resolved
|
@maskaravivek Are any more changes required? :) |
|
Hi @ShridharGoel , is it expected to select a media from explore and to be able to zoom in out there? I tested this but nothing changed on API 19 real device and API 26 emulator. |
|
@neslihanturan Yes, first we need to click on the media to open it in zoomable mode. |
|
Does it work for you with emulator? |
|
I had tried on a real device, it was working fine (as in the GIF). |
|
But you made some changes after adding the GIF, that's why I wanted to ask. It worked me once on an API 26 emulator, but it didn't work for long time at the beginning. Then suddenly it worked. Can you explain more which kind on click activates it? long click, double click etc. |
|
A normal single click |
|
Finally I have managed to make it work, but I have a doubt. How the user bring information sheet back, after zoomed in out? And instead of single click to activate, can we consider another solution which is more easy to find for user? |
|
Additionally, app freeze and closes on API 19 device after single click to image. Will try to share logs shortly. |
Above is the whole logs I could collect from API 19 device. It seems like too many threads are created, this explains why I hardly tested this feature on an emulator or on an old device and why the app freeze and app gets closed. You may need to check and optimize number of threads you create for this purpose, and make sure you handled them appropriately. |
neslihanturan
requested changes
Mar 19, 2019
|
Is this PR active @ShridharGoel ? |
|
Closing this PR since it seems like sleeping and it has issues that can't be solved trivially. Another fresh approach can take shorter time. |
1 similar comment
|
Closing this PR since it seems like sleeping and it has issues that can't be solved trivially. Another fresh approach can take shorter time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2421
Now, clicking on the image in media details would open up the image which can be zoomed.
Tests performed
Tested betaDebug on Android 7.1.2 (API 25).
GIF showing what changed