Skip to content

Conversation

@maskaravivek
Copy link
Contributor

@maskaravivek maskaravivek commented Feb 11, 2019

Description (required)

Fixes #1971

Uploaded this image and the upload date shows correctly:

https://commons.wikimedia.org/wiki/File:Statue_of_Angarika_Dharamapalan.jpg

@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #2438 into 2.10-release will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           2.10-release   #2438      +/-   ##
===============================================
- Coverage          5.81%   5.81%   -0.01%     
===============================================
  Files               256     256              
  Lines             12166   12172       +6     
  Branches           1092    1091       -1     
===============================================
  Hits                708     708              
- Misses            11402   11408       +6     
  Partials             56      56
Impacted Files Coverage Δ
...va/fr/free/nrw/commons/upload/UploadPresenter.java 10.98% <ø> (ø) ⬆️
...ava/fr/free/nrw/commons/upload/UploadActivity.java 0% <ø> (ø) ⬆️
.../commons/contributions/ContributionController.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/filepicker/UploadableFile.java 2.85% <0%> (ø)
...ava/fr/free/nrw/commons/filepicker/FilePicker.java 0% <0%> (ø) ⬆️
...n/java/fr/free/nrw/commons/upload/UploadModel.java 32.73% <0%> (-0.8%) ⬇️
...va/fr/free/nrw/commons/filepicker/PickedFiles.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86a3aa...b7ee11a. Read the comment docs.

@maskaravivek maskaravivek changed the title Fix date time issue for google photos Fix issue where original date was not being extracted correctly Feb 12, 2019
@misaochan
Copy link
Member

Thanks @maskaravivek ! Can you rebase and submit this to master? I haven't done the update to the 2.10-release branch yet. Trying to do it at the last minute so that alpha testers can keep testing the fixes. :)

@misaochan
Copy link
Member

Or, actually, I guess we can merge your PR into 2.10-release now that I have updated it, and then I'll update master so alpha users can get your changes. But you'll still have to fix the conflict. :)

@misaochan misaochan merged commit 2bc0d41 into commons-app:2.10-release Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants