Fixed nearby map not localized(Fixed #2335) #2504
Conversation
|
The "after with French" looks great, but the "after" is not correctly localized. |
Codecov Report
@@ Coverage Diff @@
## master #2504 +/- ##
=========================================
- Coverage 2.7% 2.69% -0.01%
=========================================
Files 258 258
Lines 12283 12301 +18
Branches 1113 1115 +2
=========================================
Hits 332 332
- Misses 11925 11943 +18
Partials 26 26
Continue to review full report at Codecov.
|
|
@nicolas-raoul I am not sure if it's possible with wikimedia tiles. I uploaded a screenshot of Wikimedia app nearby map, the map language in China Shenzhen is in Chinese even my Android system language is English. Also I checked Google Maps, it is more friendly localized but even it does not have much differences in English and French system languages in China Shenzhen city. Also I am not a map master and not sure if mapbox with wikimedia tiles can do things like Google Maps did.
|
|
@zhao-gang Just wanted to check if this PR fixes the issue and is it ready for testing? :) |
|
@mashawan Yes. It can be tested. Also changed the PR's title to indicate what it really did. |
|
This PR updated mapbox sdk version and added a new dependency to mapbox localization plugin. I checked the beta release apk size changed from 14883136 to 14962535. Just FYI :-) |
|
After reading some documents I found it's easy to set preferred language for wikimedia tiles. It just needs to add a "?lang=xx" parameter to tiles url. When loading the map, add the parameter according to user's Android system default Locale. By this way it's not needed to add mapbox localization plugin and also does not need to upgrade mapbox sdk. |
…pp#2335) Wikimedia tiles support adding a "?lang=xx" suffix to tiles url to set preferred language. Use this feature to set the preferred language to user's default Locale.
|
Could you please post new screenshots showing Paris in both French and English locales? Thanks :-) |
|
Closing this as #2614 fixes the issue. |
|
Thanks for your solution @zhao-gang , even though another solution got merged your contribution is very much appreciated! :-) |
Description (required)
Fixes #2335
What changes did you make and why?
Correctly load wikimedia tiles. This seems made the map more localized.
Tests performed (required)
Tested master betaDebug on Nexus 6P with API level 27.
Screenshots showing what changed (optional - for UI changes)
It is clear that the map makes no changes with different android system language settings. But with wikimedia tiles correctly loaded, there are more localization data than before.