Fixes Lego Messages in strings.xml for "uploaded_by_myself" #2532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es the message generation in "ReasonBuilder.java". Adds translations for "uploaded_by_myself"-String in English, German, French, Spanish and Dutch.
Codecov Report
@@ Coverage Diff @@
## master #2532 +/- ##
=========================================
+ Coverage 5.9% 5.9% +<.01%
=========================================
Files 258 258
Lines 12305 12303 -2
Branches 1103 1103
=========================================
Hits 726 726
+ Misses 11520 11518 -2
Partials 59 59
Continue to review full report at Codecov.
|
maskaravivek
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes Lego Messages in strings.xml for "uploaded_by_myself"
Fixes #2498 "uploaded by myself", "used by", and several other lego messages
What changes did you make and why?
I corrected the strings for "uploaded_by_myself" in the strings.xml and changed the message generation in "ReasonBuilder.java". I also added translations for "uploaded_by_myself"-String in English, German, French, Spanish and Dutch.
Tests performed (required)
I was not able to perform tests.
Please let me know what you think of the changes and let me know if I should adjust something or change something.