removed inactive icons from the bottom panel in nearby #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskaravivek
approved these changes
Mar 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #2549 +/- ##
======================================
Coverage 5.9% 5.9%
======================================
Files 258 258
Lines 12300 12300
Branches 1104 1107 +3
======================================
Hits 726 726
Misses 11515 11515
Partials 59 59
Continue to review full report at Codecov.
|
nicolas-raoul
requested changes
Mar 7, 2019
| @@ -836,10 +836,10 @@ private void passInfoToSheet(Place place) { | |||
| updateMarker(isBookmarked, this.place); | |||
| }); | |||
|
|
|||
| wikipediaButton.setEnabled(place.hasWikipediaLink()); | |||
| wikipediaButton.setVisibility(place.hasWikipediaLink()==true?View.VISIBLE:View.GONE); | |||
There was a problem hiding this comment.
If place.hasWikipediaLink()?View.VISIBLE:View.GONE works, it would be better :-)
There was a problem hiding this comment.
OK I'll do that
|
@nicolas-raoul I have made the changes. Kindly review :) |
nicolas-raoul
approved these changes
Mar 8, 2019
maskaravivek
approved these changes
Mar 9, 2019
|
Thanks for approving the PR @nicolas-raoul @maskaravivek :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed inactive icons from bottom panel of nearby instead of greying them out
Fixes #2541 Removing inactive icons from the bottom panel in nearby
Changes made
Changed visibility of icons instead of disabling them
Screenshots showing what changed
