-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Migrate to androidX #2594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to androidX #2594
Conversation
2796d6e
to
58f8c9e
Compare
58f8c9e
to
7305b7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 2.10.1-debug-androidXMigration~cbd344d99
. All seems to work.
Can you make the changes requested to keep gradle.properties tidy, then happy to merge.
Codecov Report
@@ Coverage Diff @@
## master #2594 +/- ##
=========================================
+ Coverage 2.69% 2.69% +<.01%
=========================================
Files 258 258
Lines 12319 12318 -1
Branches 1117 1117
=========================================
Hits 332 332
+ Misses 11961 11960 -1
Partials 26 26
Continue to review full report at Codecov.
|
@domdomegg Thanks for reviewing and testing this PR. I made the requested changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 2.10.1-debug-androidXMigration~6467db5ef
on API level 28
, 25
, 19
.
Tested 2.10.1-debug-androidXMigration~6467db5ef
on API level 28
@domdomegg Can the PR be merged? I have other changes that I would like to do once this is merged to master. :) |
Description (required)
Fixes #2593
What changes did you make and why?
Tests performed (required)
:app:build