Skip to content

Fix #2197: Fix color of links on about page in night mode #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2019
Merged

Fix #2197: Fix color of links on about page in night mode #2604

merged 1 commit into from
Mar 16, 2019

Conversation

domdomegg
Copy link
Member

This is a copy of #2199 as it accidentally got undone in #2290


Description

Fixes #2197

Tests performed

Tested 2.9.0-debug-master~b1056572 on Galaxy Nexus (emulator) with API level 28.

Checked did not break non-night mode version:

screenshot_1545330763

Screenshots showing what changed

Before After
screenshot_1545330616 screenshot_1545330684

@codecov-io
Copy link

Codecov Report

Merging #2604 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2604   +/-   ##
======================================
  Coverage    2.69%   2.69%           
======================================
  Files         258     258           
  Lines       12312   12312           
  Branches     1114    1114           
======================================
  Hits          332     332           
  Misses      11954   11954           
  Partials       26      26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf625d...4a8cfdc. Read the comment docs.

@maskaravivek maskaravivek merged commit 5b1b003 into commons-app:master Mar 16, 2019
@domdomegg domdomegg deleted the redo-2199 branch March 16, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants