Skip to content

Preventing dialog from appearing if location is enabled #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2019

Conversation

cypherop
Copy link
Contributor

Description (required)

Fixes #2634

What changes did you make and why?

Tests performed (required)

Tested ProdDebug on Motorola moto G5 plus with API level 24.

@codecov-io
Copy link

codecov-io commented Mar 17, 2019

Codecov Report

Merging #2635 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2635      +/-   ##
=========================================
- Coverage    2.77%   2.77%   -0.01%     
=========================================
  Files         259     259              
  Lines       12365   12373       +8     
  Branches     1116    1117       +1     
=========================================
  Hits          343     343              
- Misses      11995   12003       +8     
  Partials       27      27
Impacted Files Coverage Δ
...e/nrw/commons/location/LocationServiceManager.java 0% <0%> (ø) ⬆️
app/src/main/java/fr/free/nrw/commons/Media.java 1.53% <0%> (-0.04%) ⬇️
...n/java/fr/free/nrw/commons/MediaDataExtractor.java 0% <0%> (ø) ⬆️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/settings/SettingsFragment.java 0% <0%> (ø) ⬆️
...ommons/contributions/ContributionsSyncAdapter.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java 0% <0%> (ø) ⬆️
...nrw/commons/achievements/AchievementsActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24bf20...06974a3. Read the comment docs.

Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Javadoc changes requested, then I think ready to merge.

@domdomegg domdomegg merged commit 38dc0c3 into commons-app:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants