Add WelcomeActivityTest #2636
Merged
Add WelcomeActivityTest #2636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #2636 +/- ##
======================================
Coverage 2.77% 2.77%
======================================
Files 259 259
Lines 12364 12364
Branches 1116 1116
======================================
Hits 343 343
Misses 11994 11994
Partials 27 27Continue to review full report at Codecov.
|
|
Have removed WIP tag as I think we may as well merge this, and then future PRs can flesh out the tests more. Have moved the TODOs to #2644. |
|
@domdomegg Is travis running these tests at all? Codacy report doesn't show any change in the coverage. |
|
Now, that we have more instrumentation tests, it should be fine to add it back again. |
|
Merging this and travis instrumentation tests can be enabled in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Adds Android Test: WelcomeActivityTest
TODO - moved to #2644
Probably want to flesh this out a bit with some more tests. Ideally we'd have one which would swipe the correct number of times and then click 'yes', and check we were out of WelcomeActivity
Also maybe check that on beta clicking the skip tutorial exits WelcomeActivity
Also maybe check we can swipe both ways (i.e. backwards and forwards)
Also maybe check swiping beyond the proper bounds shouldn't do anything e.g. swiping left on the first page or right on the last page.