Skip to content

#2643: Standardize includes of toolbar layout #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2019
Merged

#2643: Standardize includes of toolbar layout #2646

merged 1 commit into from
Mar 19, 2019

Conversation

domdomegg
Copy link
Member

Description (required)

Works on #2643

Include toolbar.xml in the same simple way everywhere - there is no need to add the id, width, height etc. in both the caller and the template - it should just be once in the template. There are a couple of unused files which I haven't updated but these should be deleted by #2641 and I don't want to create merge conflicts.

Tests performed (required)

Tested 2.10.1-debug-refactor-toolbar~9d15e177e

Beta Commons upload

@codecov-io
Copy link

Codecov Report

Merging #2646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2646   +/-   ##
======================================
  Coverage    2.77%   2.77%           
======================================
  Files         259     259           
  Lines       12373   12373           
  Branches     1117    1117           
======================================
  Hits          343     343           
  Misses      12003   12003           
  Partials       27      27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c6888...9d15e17. Read the comment docs.

@domdomegg domdomegg mentioned this pull request Mar 18, 2019
@neslihanturan
Copy link
Collaborator

Thanks for improving the code quality @domdomegg

@neslihanturan neslihanturan merged commit fd6c482 into commons-app:master Mar 19, 2019
@domdomegg domdomegg deleted the refactor-toolbar branch March 19, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants