Fix upload card view arrow direction error (#2205)

[mrpeny]

Description

Fixes #2205 Upload card view arrow points in random direction

This is an intermittent bug, hard to reproduce but when it occurs then the bug hides in the Android native libraries where the ViewPropertyAnimator sets the rotation member variable on the arrow ImageView. Therefore I eliminated the reading of this field and set the rotation property explicitly. The rotation of the arrow is also set explicitly in the activity_upload_bottom_card.xml layout file.

Tests performed

Tested on betaDebug build variant on Galaxy_Nexus_API_28 with API level 28 with the same settings as described in the conversation below the Issue.

Screenshots showing what changed (optional - for UI changes)

[codecov-io]

Codecov Report

Merging #2653 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #2653   +/-   ##
======================================
  Coverage    2.75%   2.75%           
======================================
  Files         260     260           
  Lines       12437   12437           
  Branches     1125    1125           
======================================
  Hits          343     343           
  Misses      12067   12067           
  Partials       27      27

Impacted Files	Coverage Δ
...ava/fr/free/nrw/commons/upload/UploadActivity.java	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1040c2d...762c210. Read the comment docs.

[domdomegg]

Tested 2.10.1-debug-arrow-direction~762c21003

Beta Commons upload

[domdomegg]

@mrpeny In #2205 (comment) you mentioned you were new to the open source world and you wanted to know if anything wasn't correct. I'd like you to know that this was a perfect PR - something that is extremely rare! It's clear you've read the documentation carefully, but I really liked that you:

• Communicating very clearly about when you were working on the issue, checking who was assigned etc.
• Solved the issue quickly (it's fine if it's assigned for a few days but sometimes it can be months and it gets lost)
• Titled your commits and pull request well, referenced the issue number and named your development branch well
• Were clear about what tests were performed, and providing screenshots
• Changed the least amount of code possible so the PR is small, making it easy to review + not likely to cause serious merge conflicts
• Added the appropriate Javadoc

[mrpeny]

Thank you @domdomegg, I really appreciate your detailed answer. It is a very good impression for my about the open source world :)