[WIP] Extend WelcomeActivityTest

[vanshikaarora]

Description (required)

Fixes #2644 Extend WelcomeActivityTest

Changes Made

Test swiping the correct number of times and then clicking 'yes' exits WelcomeActivity
Test that on beta clicking the 'skip tutorial' button exits WelcomeActivity
Test we can swipe both ways (i.e. backwards and forwards)

Added the above three tests

Tests performed (required)

Tested betaDebug on vivo 1713 with API level 24.

[codecov-io]

Codecov Report

Merging #2666 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2666      +/-   ##
=========================================
+ Coverage    2.75%   2.81%   +0.06%     
=========================================
  Files         260     258       -2     
  Lines       12430   12376      -54     
  Branches     1125    1111      -14     
=========================================
+ Hits          343     349       +6     
+ Misses      12060   12001      -59     
+ Partials       27      26       -1

Impacted Files	Coverage Δ
...ree/nrw/commons/upload/ImageProcessingService.java	84.48% <0%> (-0.27%)	⬇️
...n/java/fr/free/nrw/commons/CommonsApplication.java	0% <0%> (ø)	⬆️
...ons/explore/categories/SearchCategoryFragment.java	0% <0%> (ø)	⬆️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java	0% <0%> (ø)	⬆️
...mmons/contributions/ContributionsListFragment.java	0% <0%> (ø)	⬆️
...e/nrw/commons/location/LocationServiceManager.java	0% <0%> (ø)	⬆️
...e/nrw/commons/di/CommonsDaggerSupportFragment.java	0% <0%> (ø)	⬆️
...a/fr/free/nrw/commons/utils/ImageUtilsWrapper.java	0% <0%> (ø)	⬆️
...w/commons/category/CategoryImagesListFragment.java	0% <0%> (ø)	⬆️
...s/bookmarks/pictures/BookmarkPicturesFragment.java	0% <0%> (ø)	⬆️
... and 25 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ceaaa9...1ebcd4d. Read the comment docs.

[domdomegg]

Thanks so much for adding these tests! I've left some suggestions, but the only thing that must be changed is the statement in ifSkipButtonClicked as that breaks when running tests in the prod build variant and also doesn't test the beta version correctly.

[vanshikaarora]

as that breaks when running tests in the prod build variant

@domdomegg I could't reproduce this. Can you please share the error report :)

[domdomegg]

@domdomegg I could't reproduce this. Can you please share the error report :)

You fixed this in your latest commit already :)

Will review and merge later hopefully.