Skip to content

Prevent additional possible crash(es) from improperly disposed observables. #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dbrant
Copy link
Collaborator

@dbrant dbrant commented Mar 19, 2019

You've got some additional helper classes that perform Rx operations internally on their own. These, too, need to be contained and disposed when they are no longer needed (i.e. no longer associated with an activity or fragment).

@codecov-io
Copy link

Codecov Report

Merging #2670 into master will increase coverage by 0.05%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2670      +/-   ##
=========================================
+ Coverage    2.76%   2.82%   +0.05%     
=========================================
  Files         259     259              
  Lines       12367   12375       +8     
  Branches     1112    1112              
=========================================
+ Hits          342     349       +7     
- Misses      11998   12000       +2     
+ Partials       27      26       -1
Impacted Files Coverage Δ
...ree/nrw/commons/upload/ImageProcessingService.java 84.48% <100%> (ø) ⬆️
...java/fr/free/nrw/commons/upload/FileProcessor.java 5.33% <25%> (+1.16%) ⬆️
...va/fr/free/nrw/commons/upload/UploadPresenter.java 11.04% <28.57%> (+0.37%) ⬆️
...n/java/fr/free/nrw/commons/upload/UploadModel.java 34.25% <62.5%> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6c482...c2a20ce. Read the comment docs.

@dbrant
Copy link
Collaborator Author

dbrant commented Mar 19, 2019

Consolidated into #2669

@dbrant dbrant closed this Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants