Remove unused code #2672
Merged
Remove unused code #2672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using MapBox tiles at present. Code
mapView.setStyleUrl("asset://mapstyle.json"); tries to set nearby map
tiles to wikimedia. It should be removed as it has no actual effect
and is somewhat misleading.
Codecov Report
@@ Coverage Diff @@
## master #2672 +/- ##
========================================
Coverage ? 2.77%
========================================
Files ? 258
Lines ? 12342
Branches ? 1111
========================================
Hits ? 342
Misses ? 11973
Partials ? 27
Continue to review full report at Codecov.
|
domdomegg
reviewed
Mar 19, 2019
59c77b2 to
7bc5a25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Follow up of PR #2614
We're using MapBox tiles at present. Code
mapView.setStyleUrl("asset://mapstyle.json"); tries to set nearby map
tiles to wikimedia. It should be removed as it has no actual effect
and is somewhat misleading.
Tests performed (required)
Tested current master ProdDebug on Nexus 6P with API level 27.