Convert instrumentation tests to Kotlin #2689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2689 +/- ##
======================================
Coverage 2.81% 2.81%
======================================
Files 258 258
Lines 12376 12376
Branches 1111 1111
======================================
Hits 349 349
Misses 12001 12001
Partials 26 26Continue to review full report at Codecov.
|
maskaravivek
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert instrumentation tests to Kotlin, as agreed in #2626 (comment)
I have noticed
NavigationBaseActivityTest.doubleNavigateToExploreThenReturnHome()seems a bit flaky, but that is present in the Java version and is not related to the Kotlin conversion. See #2688