Skip to content

Adjusted position of level number in achievements activity #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

vanshikaarora
Copy link
Contributor

Description
Adjusted layout of achievements activity to adjust vertical position of level number on all screen sizes

Fixes #2677 Level number in achievements position is a bit odd with 2 digits

Screenshot for 1 digit level number
WhatsApp Image 2019-03-21 at 2 59 11 PM

Screenshot for 2-digit level number
WhatsApp Image 2019-03-21 at 3 02 59 PM

@codecov-io
Copy link

Codecov Report

Merging #2695 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2695   +/-   ##
======================================
  Coverage    2.81%   2.81%           
======================================
  Files         258     258           
  Lines       12376   12376           
  Branches     1111    1111           
======================================
  Hits          349     349           
  Misses      12001   12001           
  Partials       26      26
Impacted Files Coverage Δ
...nrw/commons/achievements/AchievementsActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268ba07...7a41147. Read the comment docs.

@domdomegg domdomegg self-requested a review March 21, 2019 18:16
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 2.10.1-debug-level_no_achievements~7eae0afc1

@domdomegg domdomegg merged commit c17a1f9 into commons-app:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants