-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Resolves Reloading of image on moving to next question in peer review #2709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2709 +/- ##
=========================================
+ Coverage 2.72% 2.72% +<.01%
=========================================
Files 267 267
Lines 12814 12801 -13
Branches 1140 1137 -3
=========================================
Hits 349 349
+ Misses 12439 12426 -13
Partials 26 26
Continue to review full report at Codecov.
|
Please can you resolve the merge conflicts and I can review. |
@domdomegg I have resolved the merge conflicts. Kindly review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@domdomegg I have made the changes. Here is the modified UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 2.10.1-debug-peer_viewpager~7c64ff775
The "SKIP THIS IMAGE" text still looks a bit weird for me. However, I'm going to merge this as it's quite a large change and don't want to block others working on peer review with merge conflicts. Also the layout needs to be fixed in general so it's a bit pointless fiddling with minor layout things here.
Thanks for approving the PR @domdomegg :) |
Description (required)
Fixes sub-task of #2698 to stop reloading of image while moving to the next question for the same image.
Fixes #2698 Improve peer review feature quality
Changes made