Tests for welcome activity #2721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
======================================
Coverage 2.71% 2.71%
======================================
Files 267 267
Lines 12838 12838
Branches 1141 1141
======================================
Hits 349 349
Misses 12463 12463
Partials 26 26Continue to review full report at Codecov.
|
maskaravivek
approved these changes
Mar 23, 2019
domdomegg
reviewed
Mar 23, 2019
|
|
||
| @Test | ||
| fun swipeBeyondBounds(){ | ||
| if (!ConfigUtils.isBetaFlavour()){ |
There was a problem hiding this comment.
This test should probably still run on beta
domdomegg
reviewed
Mar 23, 2019
|
|
||
| @Test | ||
| fun swipeTillLastAndFinish(){ | ||
| if (!ConfigUtils.isBetaFlavour()){ |
There was a problem hiding this comment.
This test should probably still run on beta
|
Thanks for approving the PR @maskaravivek @domdomegg :) |
|
@vanshikaarora Can you create another PR so the two tests also run on beta (i.e. remove the if condition wrapping them) |
|
And tag me in to review it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #2644 Extend WelcomeActivityTest
Changes made
Added the above two tests
Tests performed (required)
Tested ProdDebug on vivo 1713 with API level 24.