Skip to content

Bugfix/customproxy #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)
Added a CustomProxy class, the instance of which overrides the invocationHandler() method which returns appropriate values for different datatypes instead of null for all of them. See https://stackoverflow.com/questions/52083338/expected-to-unbox-a-string-primitive-type-but-was-returned-null
Fixes #2737 App crashed with NPE in UploadPresenter due to null object returned by Proxy InvocationHandler

Tests performed (required)

Tested {ProdDebug} on {Pixel} with API level {27}.

* Added a CustomProxy class which overrides the invocation handler to return approproate values for different datatypes

(cherry picked from commit f68d2e880074277b75a60b730dd63254239a8971)
@codecov-io
Copy link

Codecov Report

Merging #2738 into master will increase coverage by 0.02%.
The diff coverage is 31.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2738      +/-   ##
=========================================
+ Coverage    2.72%   2.75%   +0.02%     
=========================================
  Files         267     268       +1     
  Lines       12801   12816      +15     
  Branches     1137    1141       +4     
=========================================
+ Hits          349     353       +4     
- Misses      12426   12437      +11     
  Partials       26      26
Impacted Files Coverage Δ
...va/fr/free/nrw/commons/upload/UploadPresenter.java 12.63% <100%> (+1.58%) ⬆️
...in/java/fr/free/nrw/commons/utils/CustomProxy.java 7.14% <7.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbab7dd...f40f692. Read the comment docs.

@misaochan misaochan requested a review from maskaravivek March 25, 2019 08:29
@maskaravivek maskaravivek merged commit f7f88d5 into commons-app:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants