-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Consistent handling of web and geo urls #2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@neslihanturan Thanks for approving the PR. I have removed google map intent and have made it generic. So now if the device has an app capable of handling map then it will be opened. |
Codecov Report
@@ Coverage Diff @@
## master #2750 +/- ##
=========================================
+ Coverage 2.72% 2.84% +0.11%
=========================================
Files 267 268 +1
Lines 12801 12740 -61
Branches 1137 1126 -11
=========================================
+ Hits 349 362 +13
+ Misses 12426 12353 -73
+ Partials 26 25 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for testing :) |
Description (required)
Fixes #2749