Skip to content

Consistent handling of web and geo urls #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

maskaravivek
Copy link
Member

Description (required)

Fixes #2749

@maskaravivek maskaravivek changed the title Consistent handling of web and geo urls [WIP] Consistent handling of web and geo urls Mar 25, 2019
@maskaravivek maskaravivek changed the title [WIP] Consistent handling of web and geo urls Consistent handling of web and geo urls Mar 28, 2019
@maskaravivek
Copy link
Member Author

@neslihanturan Thanks for approving the PR. I have removed google map intent and have made it generic. So now if the device has an app capable of handling map then it will be opened.

@codecov-io
Copy link

Codecov Report

Merging #2750 into master will increase coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2750      +/-   ##
=========================================
+ Coverage    2.72%   2.84%   +0.11%     
=========================================
  Files         267     268       +1     
  Lines       12801   12740      -61     
  Branches     1137    1126      -11     
=========================================
+ Hits          349     362      +13     
+ Misses      12426   12353      -73     
+ Partials       26      25       -1
Impacted Files Coverage Δ
...main/java/fr/free/nrw/commons/location/LatLng.java 40.81% <ø> (ø) ⬆️
...ava/fr/free/nrw/commons/upload/UploadActivity.java 0% <ø> (ø) ⬆️
...ee/nrw/commons/media/MediaDetailPagerFragment.java 0% <ø> (ø) ⬆️
.../nrw/commons/category/CategoryDetailsActivity.java 0% <0%> (ø) ⬆️
...va/fr/free/nrw/commons/campaigns/CampaignView.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/nearby/PlaceRenderer.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java 0% <0%> (ø) ⬆️
.../fr/free/nrw/commons/nearby/NearbyMapFragment.java 0% <0%> (ø) ⬆️
app/src/main/java/fr/free/nrw/commons/Utils.java 22.22% <0%> (+1.04%) ⬆️
...va/fr/free/nrw/commons/upload/UploadPresenter.java 12.63% <0%> (+1.58%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d48e6...ee3beac. Read the comment docs.

Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

Copy link
Collaborator

@ashishkumar468 ashishkumar468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashishkumar468 ashishkumar468 merged commit 2021baa into commons-app:master Mar 28, 2019
@neslihanturan
Copy link
Collaborator

neslihanturan commented Mar 28, 2019

Passed from my tests, thanks @maskaravivek
Sorry already merged:)

@maskaravivek
Copy link
Member Author

Passed from my tests, thanks @maskaravivek
Sorry already merged:)

Thanks for testing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants