Add questionmark to display explanation #2783
Conversation
| } | ||
|
|
||
| private void launchAlert(String title, String message){ | ||
| new AlertDialog.Builder(ReviewActivity.this) |
There was a problem hiding this comment.
Use DialogUtil:showAlertDialog
There was a problem hiding this comment.
I think it might be better to use the info icon given we use it in the rest of the app for the same purpose - we should be consistent. (See #2698 (comment))
app/src/main/res/values/strings.xml
Outdated
| @@ -508,6 +508,10 @@ Upload your first media by tapping on the add button.</string> | |||
| <string name="review_copyright_no_button_text">SEEMS FINE</string> | |||
| <string name="review_thanks_yes_button_text">YES, WHY NOT</string> | |||
| <string name="review_thanks_no_button_text">NEXT IMAGE</string> | |||
| <string name="skip_this_image">Skip this image</string> | |||
There was a problem hiding this comment.
This string is duplicated
Codecov Report
@@ Coverage Diff @@
## master #2783 +/- ##
=========================================
- Coverage 3.84% 3.83% -0.01%
=========================================
Files 267 267
Lines 12523 12535 +12
Branches 1082 1082
=========================================
Hits 481 481
- Misses 12009 12021 +12
Partials 33 33
Continue to review full report at Codecov.
|
|
@maskaravivek @neslihanturan @domdomegg
Kindly review |
app/src/main/res/values/strings.xml
Outdated
| @@ -508,6 +508,10 @@ Upload your first media by tapping on the add button.</string> | |||
| <string name="review_copyright_no_button_text">SEEMS FINE</string> | |||
| <string name="review_thanks_yes_button_text">YES, WHY NOT</string> | |||
| <string name="review_thanks_no_button_text">NEXT IMAGE</string> | |||
| <string name="go_back_button_text">GO BACK</string> | |||
| <string name="skip_image_explanation">Clicking this button will give you another recently uploaded image from Wikimedia Commons</string> | |||
| <string name="review_image">Peer Review</string> | |||
There was a problem hiding this comment.
Duplicate of title_activity_review
| DialogUtil.showAlertDialog(ReviewActivity.this, | ||
| getString(R.string.review_image), | ||
| getString(R.string.review_image_explanation), | ||
| getString(R.string.about_translate_proceed), |
There was a problem hiding this comment.
Maybe better to use android.R.string.ok, 'proceed' seems a bit formal and also sounds like you're about to take action which might confuse users - I feel 'ok' is more that just you're done reading the explanation.
| getString(R.string.review_image), | ||
| getString(R.string.review_image_explanation), | ||
| getString(R.string.about_translate_proceed), | ||
| getString(R.string.go_back_button_text), |
There was a problem hiding this comment.
Probably no need to have a go back button here
| getString(R.string.skip_image_explanation), | ||
| getString(R.string.about_translate_proceed), | ||
| getString(android.R.string.cancel), | ||
| () -> runRandomizer(),null); |
There was a problem hiding this comment.
I think it might be easier (based off the behaviour of other information icons in the app - see achievements and nearby tab for examples), just to have an 'okay' button which dismisses it - not to actually skip the image on clicking 'proceed'. In that case we can remove the cancel button, and change the positive text to android.R.string.ok
|
Hello @domdomegg, |
|
Removed unused string. |
Description
Adding a question mark next to "skip this image" button and Peer Review title which will display an explanation about their usage.
Fixes #2698 Improve peer review feature quality
Tests performed
Tested betaDebug on Realme 2 pro (Android Version 8.1.0) with API level 27.
Screenshots of the result