Skip to content

Removed duplicate File: from deletion notification #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

madhurgupta10
Copy link
Collaborator

Description
Removed duplicate File: from deletion notification

Fixes #2794 Deletion request notification goes to wrong URL

Tests performed
Tested betaDebug on Xiaomi Mi A1 with API level 28 stock.

@domdomegg domdomegg requested review from domdomegg and removed request for domdomegg March 28, 2019 22:28
@domdomegg
Copy link
Member

I've tested on Beta Commons. Can you test this on real Commons? Maybe a solution would be to find a file that should be nominated for deletion (check recent uploads) and nominate that. Then please record the GIF and post back here.

@madhurgupta10
Copy link
Collaborator Author

@domdomegg Tested and Passed
ezgif com-video-to-gif (2)

@domdomegg domdomegg merged commit 3876e1c into commons-app:master Mar 29, 2019
@madhurgupta10 madhurgupta10 deleted the issue-2794 branch March 29, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants