Skip to content

Fixed Night Mode Problem in Spinner #2809 #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

madhurgupta10
Copy link
Collaborator

Description

Fixes #2809 Night Mode: Language Selection dialog is not readable

Tests performed

Tested betaDebug on Xiaomi Mi A1 with API level 28 stock.

Screenshots showing what changed

Screenshot_20190331-015907

@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #2826 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2826      +/-   ##
=========================================
+ Coverage    3.83%   3.83%   +<.01%     
=========================================
  Files         267     267              
  Lines       12534   12532       -2     
  Branches     1082    1082              
=========================================
  Hits          481     481              
+ Misses      12020   12018       -2     
  Partials       33      33
Impacted Files Coverage Δ
...ee/nrw/commons/upload/SpinnerLanguagesAdapter.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b0f40...09ebede. Read the comment docs.

@neslihanturan neslihanturan self-requested a review April 1, 2019 10:18
@neslihanturan
Copy link
Collaborator

Thanks @madhurgupta10 ! Just a quick note, please try to be more clear on your issues and PRs. Ie, expected, found comparaisons, and some written explnation would help.

@neslihanturan neslihanturan merged commit 01696cc into commons-app:master Apr 1, 2019
@madhurgupta10
Copy link
Collaborator Author

@neslihanturan I will definitely keep this in mind from now , thanks for the suggestion :)

@madhurgupta10 madhurgupta10 deleted the issue-2809 branch April 2, 2019 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants