Skip to content

Fixed #2825 where user was able to add one lang twice #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

madhurgupta10
Copy link
Collaborator

Description

Fixes #2825 The user should not be allowed to add the same language twice.

What changes did you make and why?

I added a check, where the first non selected language index will be picked instead of a static index.

Tests performed

Tested betaDebug on Xiaomi Mi A1 with API level 28.

@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #2834 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2834      +/-   ##
=========================================
- Coverage    3.43%   3.43%   -0.01%     
=========================================
  Files         246     246              
  Lines       12156   12166      +10     
  Branches     1064    1067       +3     
=========================================
  Hits          418     418              
- Misses      11707   11717      +10     
  Partials       31      31
Impacted Files Coverage Δ
...r/free/nrw/commons/upload/DescriptionsAdapter.java 0% <0%> (ø) ⬆️
...ava/fr/free/nrw/commons/review/ReviewActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4578600...13dd2d0. Read the comment docs.

@madhurgupta10
Copy link
Collaborator Author

madhurgupta10 commented Apr 2, 2019

@neslihanturan I have added comments :)

@neslihanturan
Copy link
Collaborator

Thanks works as intended for me @madhurgupta10

@neslihanturan neslihanturan merged commit 0289ae1 into commons-app:master Apr 2, 2019
@madhurgupta10 madhurgupta10 deleted the issue-2825 branch April 2, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants