Skip to content

Conversation

@madhurgupta10
Copy link
Collaborator

@madhurgupta10 madhurgupta10 commented Apr 4, 2019

Description
Adjusted the gravity of SKIP THIS IMAGE Fixed for both portrait mode and landscape mode.

Fixes #2848 Skip this image title should be in center in landscape mode

Tests performed
Tested betaDebug on Xiaomi Mi A1 with API level 28 stock android.

Screenshots showing what changed
Before
Screenshot_20190404-072614

After
Screenshot_20190404-073601

@codecov-io
Copy link

Codecov Report

Merging #2849 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2849   +/-   ##
======================================
  Coverage    3.42%   3.42%           
======================================
  Files         246     246           
  Lines       12193   12193           
  Branches     1071    1071           
======================================
  Hits          418     418           
  Misses      11744   11744           
  Partials       31      31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a555c...e249f26. Read the comment docs.

@madhurgupta10
Copy link
Collaborator Author

@domdomegg @neslihanturan Could you please review this change :)

@domdomegg domdomegg self-requested a review April 15, 2019 07:40
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@neslihanturan neslihanturan merged commit 84637c5 into commons-app:master Apr 16, 2019
@madhurgupta10 madhurgupta10 deleted the issue-2848 branch April 16, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip this image title should be in center in landscape mode

4 participants