Moved hardcoded URLs to a constant file Fixed #2850 #2851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2851 +/- ##
=========================================
+ Coverage 3.64% 3.69% +0.04%
=========================================
Files 244 247 +3
Lines 12190 12217 +27
Branches 1078 1083 +5
=========================================
+ Hits 444 451 +7
- Misses 11712 11732 +20
Partials 34 34
Continue to review full report at Codecov.
|
nicolas-raoul
approved these changes
Apr 4, 2019
Member
nicolas-raoul
left a comment
There was a problem hiding this comment.
Not tested but looks good to me.
Collaborator
Author
|
@maskaravivek changes made as per the discussion |
| static final String CREDITS_URL = "https://github.com/commons-app/apps-android-commons/blob/master/CREDITS"; | ||
| static final String FAQ_URL = "https://github.com/commons-app/apps-android-commons/wiki/Frequently-Asked-Questions"; | ||
| static final String PLAY_STORE_URL = "https://play.google.com/store/apps/details?id=fr.free.nrw.commons"; | ||
| static final String TRANSLATE_WIKI_URL = "https://translatewiki.net/w/i.php?title=Special:Translate&group=commons-android-public static final Strings&filter=%21translated&action=translate&language="; |
Collaborator
There was a problem hiding this comment.
This string seems problematic, can you verify @madhurgupta10 ?
Collaborator
Author
There was a problem hiding this comment.
@neslihanturan Fixed. Sorry for the Typo, I used "find and replace" from the android studio and did not notice, this also got changed.
Collaborator
There was a problem hiding this comment.
Find and replace is quite risky:)
neslihanturan
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved the hardcoded URLs to a constant file so that the code is easier to maintain, also it removed the duplicate strings :)
Fixes #2850 Moving URLs from About Activity to build.gradle
Tests performed
Tested betaDebug on Xiaomi Mi A1 with API level 28 stock android.