Skip to content

Fixed Width of Navigation Drawer for Tablets #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2019

Conversation

madhurgupta10
Copy link
Collaborator

Description
Fixed Width of Navigation Drawer for Tablets.

Fixes #2854 Navigation Drawer is huge in Tablets

Tests performed
Tested betaDebug on Custom Tablet 9inch with API level 28 stock android.

Screenshots showing what changed
screenshot-2019-04-04_15 27 43 758
screenshot-2019-04-04_15 28 00 006

@codecov-io
Copy link

Codecov Report

Merging #2856 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2856      +/-   ##
=========================================
+ Coverage    3.42%   3.42%   +<.01%     
=========================================
  Files         246     246              
  Lines       12193   12187       -6     
  Branches     1071    1071              
=========================================
  Hits          418     418              
+ Misses      11744   11738       -6     
  Partials       31      31
Impacted Files Coverage Δ
...free/nrw/commons/theme/NavigationBaseActivity.java 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a555c...39542de. Read the comment docs.

@madhurgupta10
Copy link
Collaborator Author

@nicolas-raoul Could you please review this PR :)

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test now, but the code looks good, I mean removing counter-productive code is always a positive thing :-)

@madhurgupta10
Copy link
Collaborator Author

@neslihanturan Could you please test and merge?

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neslihanturan neslihanturan merged commit 867cc99 into commons-app:master May 8, 2019
@madhurgupta10 madhurgupta10 deleted the issue-2854 branch May 10, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Drawer is huge in Tablets
4 participants