-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update to Gradle 5 #2860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 5 #2860
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2860 +/- ##
======================================
Coverage 3.74% 3.74%
======================================
Files 249 249
Lines 12102 12102
Branches 1070 1070
======================================
Hits 453 453
Misses 11615 11615
Partials 34 34 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, waiting on #2868 to merge as unsure if this breaks Espresso tests too.
I am on board with the Gradle update. Not so sure about adding the dependency. Could you please elaborate on what import errors are being experienced, and how the dependency fixes them? Also, should that be in a separate PR from the Gradle update as it addresses a different issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment above.
I believe it's been added to build.gradle as it should really have been an app dependency, but previously it just worked because either Gradle 4 added it automatically or some other library we use depended on it. As this updates Gradle to Gradle 5, the dependency is no longer automatically included. So really this PR does not add a dependency, it just makes it explicit. |
Ah, thanks for clarifying! In that case I am good with it. Sorry for the slow response, as I have just returned back from the hackathon trip. :) |
d5d3598
to
da7ed5f
Compare
This reverts commit 30df302.
Description (required)
Fixes #2824 Update to Gradle 5
What changes did you make and why?
Updated Gradle from version 4.10 to 5.3.1 to
get faster builds and help towards fixing #1941.
Added 'org.apache.commons:commons-lang3:3.8.1'
to fix import errors.
Tested {betaDebug} on Nexus 5X Emulator with API level {24}.
Screenshots showing what changed (optional - for UI changes)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.