Skip to content

Conversation

@neslihanturan
Copy link
Collaborator

Description (required)

Fixes #2922 We used to see a beta login alert text when we login to beta account previously. Somehow it has gone, this PR puts it back.

Tests performed (required)

Tested with betaDebug and prodDebug on API 26 emulator

Screenshots showing what changed (optional - for UI changes)
Screenshot from 2019-04-25 14-04-46

@codecov-io
Copy link

Codecov Report

Merging #2928 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2928   +/-   ##
======================================
  Coverage    3.64%   3.64%           
======================================
  Files         245     245           
  Lines       12194   12194           
  Branches     1078    1078           
======================================
  Hits          444     444           
  Misses      11716   11716           
  Partials       34      34
Impacted Files Coverage Δ
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d28c6...abece97. Read the comment docs.

Copy link
Collaborator

@ashishkumar468 ashishkumar468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me, Thanks for the PR @neslihanturan

@ashishkumar468 ashishkumar468 merged commit d22884f into commons-app:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beta accound alert is missing

3 participants