Fix loading of images in contributions list #2932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #2892
What changes did you make and why?
Earlier,
ContributionViewHolder
was trying to set the image url onSchedulers.io()
thread. The fix was to useAndroidSchedulers.mainThread()
instead.Also, I have re-added
LruCache
which was removed in #2906. So now, in an app session, a thumbnail would be fetched only once for a filename.Tests performed (required)
Tested on prod debug API 27.
Screenshots showing what changed (optional - for UI changes)