Merge 2.10 with master #2938
Merged
Merge 2.10 with master #2938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added wikidataEntityID in all db versions, handled db.execSql via method runQuery
* Update changelog.md * Versioning for v2.10.2 * Update changelog.md
* Corrected string placedholders in certain string files * Corrected string placedholders in certain string files[Bug fix commons-app#2580]
* Bug Fix commons-app#2585 * Added null checks on view in SearchImageFragment when updating views from external sources * Disposed the disposables in SearchActivity and SearchImageFragment when no longer in active lifecycle * use FragmentUtils to verify fragment active state
* Bug Fix issue commons-app#2648 * Handled external storage permission before file download * * Removed redudant check for permission in MediaDetailPagerFragment (Dexter already does that) * Removed duplicate code in PermissionUtil$checkPermissionsAndPerformAction, used the existing function with conditional extra parameters * string name typo correction
* Addded null check on bookmark before operating on it
* Added null checks in OkHttpJsonApiClient$searchImages MwQueryResponse
* Handled null auth cookies
* Handled Illegal State Exception for non existent appropriate view parents in ViewUtils$showShortSnackbar
BugFix deprecated licenes commons-app#2720
Codecov Report
@@ Coverage Diff @@
## master #2938 +/- ##
======================================
Coverage 3.69% 3.69%
======================================
Files 246 246
Lines 12219 12219
Branches 1083 1083
======================================
Hits 451 451
Misses 11734 11734
Partials 34 34
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synced master with 2.10
Tested uploads on betaDebug on OnePlus 3T